Skip to content

[Insight] Refactored Tx Data with Boxes and Underlines #3929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 1, 2025
Merged

[Insight] Refactored Tx Data with Boxes and Underlines #3929

merged 20 commits into from
Jul 1, 2025

Conversation

MicahMaphet
Copy link
Contributor

@MicahMaphet MicahMaphet commented Jun 10, 2025 •
edited
Loading

  • Fieldset border boxes labeling tx details [1]
  • Tx details uses all available space [2]
  • Bullet point circle for unspendable transactions [3]
  • Underline for tx header when showing details [4]

Old:
image
[1][2][4] New:
image

[3]image
image

MicahMaphet added 14 commits June 4, 2025 00:37
@MicahMaphet
created outline box with label within lines for transactions details
206ce69
@MicahMaphet
made box aligns around inner text
71ef164
@MicahMaphet
put components inside of border labeled boxes
dfcce6f
@MicahMaphet
redid border box with field set
093f428
@MicahMaphet
box taked minimum room
019a4f1
@MicahMaphet
made transaction input and output columns use all space
a47f52f
@MicahMaphet
refactored element structure for tx details, improving spacing, paddi…
68ae9cf 
…ng, margin etc
@MicahMaphet
added text wrapping for tx data elements; put Tx Index and Confirmati…
5e0c47e 
…ons next to each other and touched up colors and lines
@MicahMaphet
fixed hover for address and Unparsed address+OP_RETURN spacing
9bf501c
@MicahMaphet
Merge branch 'spent-arrow' into border-box-label
8085f6a
@MicahMaphet
added circle placeholder to unspendable txs
4f6f9dd
@MicahMaphet
added back fit content to border box
905dbf0
@MicahMaphet
removed quotes around 0
fbe97eb
@MicahMaphet
added automatic margin removal to BorderBoxLabel children for more co…
c43faff 
…nsistent box sizing in tx details
@MicahMaphet
Copy link
Contributor Author

MicahMaphet commented Jun 10, 2025 •
edited
Loading

Copy text for TX id:
image
These changes are on the txdetail-copytext branch.

@MicahMaphet MicahMaphet marked this pull request as ready for review June 11, 2025 14:38
kajoseph
kajoseph requested changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@kajoseph kajoseph left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just a couple of pieces of feedback:

  1. Let's change the color of the spent arrows to be #2850EF. It's a little easier on the eyes in dark mode.
  2. Let's remove the cursor change from arrows that aren't links (e.g. unspent/unspendable outputs).

kajoseph
kajoseph reviewed Jun 30, 2025
View reviewed changes
@kajoseph kajoseph merged commit 23fdff6 into bitpay:master Jul 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kajoseph kajoseph kajoseph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MicahMaphet @kajoseph